-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-gatsby): Add -y flag #28468
Conversation
I like the idea, but I'm not sure about the implementation. This fails silently if the kebabified version of the name is invalid, or the folder exists. I also think that a |
@@ -79,6 +82,7 @@ export const questions = (initialFolderName: string): any => [ | |||
initial: initialFolderName, | |||
format: (value: string): string => c.cyan(value), | |||
validate: validateProjectName, | |||
skip, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we're still calling this question with an initial folder name to process the results but skipping it so that the user isn't prompted. Theoretically we could create the data object directly, but this seemed cleaner.
This flag bypasses all prompts other than naming your site.
[ch20045]